Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce the logging for last refreshed to only happen on an hourly basis #2918

Merged
merged 2 commits into from
Jan 18, 2024
Merged

reduce the logging for last refreshed to only happen on an hourly basis #2918

merged 2 commits into from
Jan 18, 2024

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Jan 18, 2024 •
edited
Loading

WHAT DOES THIS PR DO?

  • reduce the logging for last refreshed to only happen on an hourly basis

HOW DO I TEST OUT THIS PR?

cd src/device-registry
npm install
npm run dev-mac

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

  • get events

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a94f760) 30.93% compared to head (09103af) 30.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2918      +/-   ##
===========================================
+ Coverage    30.93%   30.97%   +0.04%     
===========================================
  Files          184      184              
  Lines        23844    23813      -31     
  Branches      3061     3055       -6     
===========================================
  Hits          7377     7377              
+ Misses       16350    16319      -31     
  Partials       117      117
Files Coverage Δ
src/device-registry/bin/kafka-consumer.js 35.59% <0.00%> (ø)
src/device-registry/models/Event.js 8.16% <0.00%> (+0.36%) ⬆️
src/device-registry/utils/create-event.js 16.20% <0.00%> (+0.27%) ⬆️

@github-actions GitHub Actions
Copy link
Contributor

Device registry changes in this PR available for preview here

@github-actions GitHub Actions
Copy link
Contributor

Device registry changes in this PR available for preview here

@Baalmart Baalmart merged commit 4fd5f85 into staging Jan 18, 2024
47 of 48 checks passed
@Baalmart Baalmart deleted the downtime-email-alerts branch January 18, 2024 16:11
@Baalmart Baalmart mentioned this pull request Jan 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Baalmart